Skip to content

chore(l1): remove blockchain clones #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

chore(l1): remove blockchain clones #4752

wants to merge 28 commits into from
+72 −77

Conversation

SDartayet
Copy link
Contributor

@SDartayet SDartayet commented Oct 2, 2025 •
edited
Loading

Motivation

Keeping track of removing clones in our codebase, and removing them where possible.

Description

This PR goes over all the clones in the blockchain crate, removing them where possible and justifying the necessary ones. Additionally, for the ones that could potentially be removed but doing so involves some larger refactors, a todo-clone comment is added

Part of #4668

@github-actions github-actions bot added the L1 Ethereum client label Oct 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 11
Total lines changed: 11

Detailed view 
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs  | 883   | -4   |
+-----------------------------------------+-------+------+
| ethrex/crates/blockchain/fork_choice.rs | 128   | -1   |
+-----------------------------------------+-------+------+
| ethrex/crates/blockchain/payload.rs     | 659   | -1   |
+-----------------------------------------+-------+------+
| ethrex/crates/blockchain/smoke_test.rs  | 236   | -5   |
+-----------------------------------------+-------+------+

@SDartayet SDartayet force-pushed the remove-blockchain-clones branch from 843732f to 9dd801d Compare October 13, 2025 15:01
@SDartayet SDartayet marked this pull request as ready for review October 14, 2025 18:41
@SDartayet SDartayet requested a review from a team as a code owner October 14, 2025 18:41
JereSalo
JereSalo reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed it and everything seems to be okay.
For me some of the comments feel kind of unnecessary and the removed clones don't seem to be important either, I think we should've approached this differently, first measuring impact and then acting upon that. But if another reviewer thinks we should merge it I'm okay with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JereSalo JereSalo JereSalo left review comments

@fmoletta fmoletta fmoletta approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@SDartayet SDartayet

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SDartayet @JereSalo @fmoletta